Skip to content

Draft: Add extra logging for test #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Draft: Add extra logging for test #1392

wants to merge 4 commits into from
+42 −16

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 17, 2025

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.43%. Comparing base (b1947ec) to head (7afdfa7).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
internal/watcher/file/file_watcher_service.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1392      +/-   ##
==========================================
+ Coverage   86.31%   86.43%   +0.12%     
==========================================
  Files         102      102              
  Lines       12603    12624      +21     
==========================================
+ Hits        10878    10912      +34     
+ Misses       1249     1233      -16     
- Partials      476      479       +3
Files with missing lines Coverage Δ
internal/file/file_manager_service.go 76.01% <100.00%> (+0.62%) ⬆️
internal/file/file_plugin.go 79.63% <100.00%> (+0.07%) ⬆️
internal/watcher/watcher_plugin.go 80.11% <100.00%> (+1.50%) ⬆️
internal/watcher/file/file_watcher_service.go 81.76% <75.00%> (+1.49%) ⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1947ec...7afdfa7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aphralG